Fix arm builds #1400
Merged
Fix arm builds #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: André Oliveira <oliveira.andrerodrigues95@gmail.com> (cherry picked from commit f669bad)
This was referenced Oct 17, 2023
2 tasks
|
Are we waiting for a nightly build or is one in the pipeline? |
Running right now... https://github.com/ferdium/ferdium-app/actions/runs/6553146197 .... and its done. |
Sorry! Yes, it is published as 6.5.2-nightly.4 or 6.5.2 |
|
Wonderful, it's in place now, services updated and all seem right now! Oddly enough it feels even a little snappier than before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: André Oliveira oliveira.andrerodrigues95@gmail.com
(cherry picked from commit f669bad)
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Fix arm builds (all OS) and add back (necessary) tweak on
pnpm.cjsfor Windows buildsMotivation and Context
This PR closes #1360 and #1387
Thank you @Alphrag for working on this with my (minor) help!
Thank you @ylluminate and @bkimmett for the endless testing on
armmachines!Checklist
pnpm prepare-code)pnpm testpassesRelease Notes
fix: make
armbuilds work again