Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade 'macos-notification-state' to latest version (includes fix for node-gyp) #1792

Merged

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Jun 1, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Upgrade 'macos-notification-state' to latest version (includes fix for node-gyp)

Motivation and Context

Since macos-notification-state had a dependency on node-gyp that was failing (documented here), it was failing earlier.

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam requested a review from a team June 1, 2024 08:22
@vraravam vraravam merged commit 6f84b89 into ferdium:develop Jun 1, 2024
5 checks passed
@vraravam vraravam deleted the upgrade-macos-notification-state branch June 1, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants