-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(tabs): improve visual consistency and label handling for horizontal style #1944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@all-contributors please add @DenysMb for code |
I've put up a pull request to add @DenysMb! 🎉 |
Very strange, since I am using the SCSS $theme-brand-primary variable that should handle this. Edit: I was wrong. The accent color is controlled in the |
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
When we move the sidebar to the top and show the services label, we get a very inconsistent visual.
The service tab width is different according to the size of the service label and the active indicator pushes everything down, so the active service tab keeps unaligned with all the others.
In this PR I fixed both issues by using a fixed width for all the tabs when labels are displayed and using box-shadow instead of a border for the active tab indicator so things are not pushed down, This way we have a more consistent look for all the tabs and the whole application in general.
Another problem is that the long labels were not "ellipsed, I fixed this too.
Motivation and Context
I prefer to use the tabs at the top of the application, but all these little issues prevented me from doing so because they bothered me a lot.
Screenshots
Before:
After:
Checklist
pnpm prepare-code
)pnpm test
passesRelease Notes