feat: support for the new slack ui #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecialAro
reviewed
Sep 25, 2023
Comment on lines
+44
to
+56
| const oldSlackUiTeamMenu = document.querySelector( | ||
| '#team-menu-trigger, .p-ia__sidebar_header__team_name', | ||
| ); | ||
| const newSlackUiTeamMenu = document.querySelector( | ||
| '.p-ia4_home_header_menu__button', | ||
| ); | ||
|
|
||
| if (oldSlackUiTeamMenu || newSlackUiTeamMenu) { | ||
| if (oldSlackUiTeamMenu) { | ||
| oldSlackUiTeamMenu.click(); | ||
| } else if (newSlackUiTeamMenu) { | ||
| newSlackUiTeamMenu.click(); | ||
| } |
There was a problem hiding this comment.
Haven't tested it (I don't use slack). But instead of this, can't we use an array of strings on which we pass all the query selectors (old and new)? Given that the logic for both new and old just vary on the query selector?
There was a problem hiding this comment.
Not sure how that would look like, feel free to push a commit simplifying this!
I wasn't planning on keeping this code around for the long run and remove the old slack UI code in a couple of months.
There was a problem hiding this comment.
Lets go with your fix and then change it in a couple of months (when the new UI sticks) 😄 Thank you!
- update selector for team menu to work with new and old slack ui - bump slack recipe to v1.6.0
SpecialAro
force-pushed
the
feat/1371-support-for-the-new-slack-ui
branch
from
f406bc0 to
63645c3
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
References ferdium/ferdium-app#1371
Screenshots
Slack service has the icon again:
