Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Launcher: Add Error Handling for LOGOS_UID #170

Closed
thw26 opened this issue Mar 21, 2023 · 0 comments · Fixed by #171
Closed

Launcher: Add Error Handling for LOGOS_UID #170

thw26 opened this issue Mar 21, 2023 · 0 comments · Fixed by #171
Labels
bug Something isn't working

Comments

@thw26
Copy link
Collaborator

thw26 commented Mar 21, 2023

The following lines fail after initial install but succeed after the user logs in.

LOGOS_UID="\$(find "\${HERE}/data/wine64_bottle/drive_c/users/\${LOGOS_USER}/AppData/Local/Logos/Data/"* -maxdepth 0 -type d | awk -F'/' '{print \$NF}')"; export LOGOS_UID;
if [ -z "LOGOS_UID" ]; then LOGOS_UID="NoUser"; export LOGOS_UID; fi

https://github.com/ferion11/LogosLinuxInstaller/blob/master/Launcher-Template.sh#L47-L48

When the find command fails to find the UID, the error/warning confuses users. Error handling should be added so that this command does not report a problem on first install.

Note that line 48 is referenced by the backup and restore commands. If NoUser is found, the backup/restore commands will throw an error that the user must log in before using the commands:

backup

restore

@thw26 thw26 added the bug Something isn't working label Mar 21, 2023
@thw26 thw26 changed the title Launcher: Add Error Handling Launcher: Add Error Handling for LOGOS_UID Mar 21, 2023
thw26 added a commit to thw26/LogosLinuxInstaller that referenced this issue Mar 28, 2023
@thw26 thw26 linked a pull request Mar 28, 2023 that will close this issue
thw26 added a commit that referenced this issue Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant