Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Reconfigure Scripts, or, Code Cleanup #81

Closed
thw26 opened this issue Oct 26, 2022 · 1 comment · Fixed by #98
Closed

Reconfigure Scripts, or, Code Cleanup #81

thw26 opened this issue Oct 26, 2022 · 1 comment · Fixed by #98

Comments

@thw26
Copy link
Collaborator

thw26 commented Oct 26, 2022 •
edited
Loading

Presently there are functions and variables mixed in with the actual run of the script. Functions and variables should be declared beforehand rather than during run.

There are also commented out sections that can be removed.

Further, functions and code should ideally be more thoroughly commented.
@thw26 thw26 changed the title Reconfigure Scripts Reconfigure Scripts, or, Code Cleanup Oct 26, 2022
@thw26
Copy link
Collaborator Author

thw26 commented Nov 22, 2022 •
edited
Loading

#95 has provided a partial fix for this. The code needs further review and commenting.

@thw26 thw26 mentioned this issue Nov 29, 2022
Merged
5 tasks
thw26 added a commit to thw26/LogosLinuxInstaller that referenced this issue Dec 14, 2022
@thw26
Provide additional clean up for ferion11#81.
28f37a1
thw26 added a commit to thw26/LogosLinuxInstaller that referenced this issue Dec 15, 2022
@thw26
Provide additional clean up for ferion11#81.
c3a12c1
@thw26 thw26 linked a pull request Dec 23, 2022 that will close this issue
Combine Versions #98
Merged
5 tasks
@thw26 thw26 closed this as completed in #98 Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Combine Versions thw26/LogosLinuxInstaller
1 participant
@thw26