Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tarfile file-size checks #470

Merged
merged 3 commits into from
Aug 30, 2023
Merged

tarfile file-size checks #470

merged 3 commits into from
Aug 30, 2023

Conversation

marcmengel
Copy link
Contributor

Checking the file size while we convert tarfiles, and raising an exception for files > 1G, which would fail later when and RCDS upload is attempted.

@marcmengel marcmengel linked an issue Aug 25, 2023 that may be closed by this pull request
Copy link
Collaborator

@shreyb shreyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick

lib/tarfiles.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@shreyb shreyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyb shreyb added this to the 1.4.1 milestone Aug 30, 2023
@shreyb shreyb merged commit e105b70 into master Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn about large files in tarfiles
2 participants