log host and time #496
Merged
log host and time #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shreyb
requested changes
Nov 8, 2023
There was a problem hiding this comment.
args.verbose is parsed from the args as an int (see get_parser.py). So we either should convert it to a bool somehow before calling log_host_time, or have log_host_time accept verbose as an int.
Given python's typing system, it most likely would work as is, but in the interest of keeping the code cleaner, I'd prefer we stay consistent with the typing of vars we're passing around.
Otherwise, it looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log host and time to stderr if verbose/debug and to Jaeger trace, per #493