If cigetcert fails for any reason, raise PermissionError
#572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #570.
This PR also adds two new unit tests to check the new logic, as well as a minor bug fix for the existing getProxy tests themselves.
Note: According to the docs:
there are two ways to check if a
subprocess.run()
call fails:check=True
kwarg to the function, which will make it raise aCalledProcessError
if the return code of the underlying subprocess is nonzero (i.e.subprocess.run('exit 1', check=True)
will raise aCalledProcessError
), andcheck=False
, and then save the return value ofsubprocess.run()
to a variable (e.g.result
). Then, when you're ready, you can runresult.check_returncode()
, which will raise theCalledProcessError
if the return code is nonzero.We use the second method here, since we want to raise different errors based on the output of
cigetcert
.