Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cargo.toml): bump spin crates #102

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

vdice
Copy link
Member

@vdice vdice commented Sep 25, 2023

Bumps to current HEAD commit of Spin, particularly to get fermyon/spin@d041cc0

Closes #101

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@itowlson
Copy link
Contributor

This makes me wonder if we should be flagging the change to folks like the containerd shim maintainers.

@vdice
Copy link
Member Author

vdice commented Sep 25, 2023

This makes me wonder if we should be flagging the change to folks like the containerd shim maintainers.

Ah, in case example or template apps are used from main/canary with the 1.5.0-based shim? If that is a likely possibility, we might consider changing the example and template apps back (eg re-adding the base config) until after the shim updates to the next Spin release...

@itowlson
Copy link
Contributor

The templates still have base (at least for now) so there's a good chance they won't come across it. But yes, generally, because it's plausible that people will try to run 1.6 apps on k8s and get a surprising error.

I wonder if in future we should consider minor versions of the manifest format for stuff like this - at least then a host could say "hey you need to update me" rather than "missing required element."

@vdice
Copy link
Member Author

vdice commented Sep 26, 2023

I wonder if in future we should consider minor versions of the manifest format for stuff like this - at least then a host could say "hey you need to update me" rather than "missing required element."

That seems like a good idea to me.

@vdice vdice merged commit 848fe34 into fermyon:main Sep 26, 2023
8 checks passed
@vdice vdice deleted the chore/bump-spin-crates branch September 26, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spin deploy error missing base
3 participants