Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database printing to show all of an app's databases #106

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

kate-goldenring
Copy link
Collaborator

Before fix:

$ spin cloud sqlite list
+------+-------+----------+
| App  | Label | Database |
+=========================+
| todo | hello | mydb     |
+------+-------+----------+

After fix

$ spin cloud sqlite list
+------+---------+--------------------+
| App  | Label   | Database           |
+=====================================+
| todo | default | brilliant-kangaroo |
|------+---------+--------------------|
| todo | hello   | mydb               |
+------+---------+--------------------+

@kate-goldenring
Copy link
Collaborator Author

Realized the key should take into account label name too since an app could theoretically point to the same db through a different label. Will update

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@kate-goldenring kate-goldenring merged commit 3aeea78 into fermyon:main Sep 29, 2023
8 checks passed
@kate-goldenring kate-goldenring deleted the fix-database-printing branch September 29, 2023 21:39
@itowlson
Copy link
Contributor

itowlson commented Oct 1, 2023

What would be the impact of removing the row of dashes between lines? It adds a lot of vertical space, but I can see the value for readability if we anticipate app names being highly variable in length. Or if we dashed only between apps rather than between every line?

@kate-goldenring
Copy link
Collaborator Author

@itowlson I'd be happy with removing the dashes between rows. I also am looking to add json outputting too which i expect would be used for larger blocks of output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants