Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silent cancellation when app db already fulfilled #108

Conversation

itowlson
Copy link
Contributor

@itowlson itowlson commented Oct 2, 2023

There is a bug in current main where if:

  • An app already exists in Cloud
  • The app declares a SQLite database
  • The SQLite database is already fulfilled

then it mistakenly returns "user cancelled" from the database linking function, causing the deployment to silently nope out. Basically apps with databases will fail to upgrade without reporting any error.

Before:

ivan@hecate:~/testing/sqlmadness$ spin cloud deploy
Uploading sqlmadness version 0.1.0-rcfcbd78 to Fermyon Cloud...
Deploying...

With this change:

ivan@hecate:~/testing/sqlmadness$ spin cloud deploy
Uploading sqlmadness version 0.1.0-r0de736f to Fermyon Cloud...
Deploying...
Waiting for application to become ready........ ready
Available Routes:
  sqlmadness: https://sqlmadness-ax7chkqb.fermyon.app (wildcard)

I don't believe the new app case is affected.

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great check 🎉

Copy link
Collaborator

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itowlson!

@kate-goldenring kate-goldenring merged commit 25ba15e into fermyon:main Oct 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants