Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sqlite): handle duplicate labels in an app manifest #121

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix(sqlite): handle duplicate labels in an app manifest #121

merged 1 commit into from
Oct 5, 2023

Conversation

kate-goldenring
Copy link
Collaborator

fixes #120

itowlson
itowlson approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mea culpa, thanks for the fix!

src/commands/deploy.rs Outdated Show resolved Hide resolved
@kate-goldenring
Handle duplicate labels in an app manifest
cf7633a 
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@vdice vdice mentioned this pull request Oct 5, 2023
Merged
@kate-goldenring kate-goldenring merged commit b05d3c2 into fermyon:main Oct 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson itowlson approved these changes

@vdice vdice vdice approved these changes

@karthik2804 karthik2804 karthik2804 approved these changes

@rylev rylev Awaiting requested review from rylev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spin app fails to deploy when two components reference NoOps DB with same label
4 participants
@kate-goldenring @itowlson @vdice @karthik2804