Move some cloud functions to an extension #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure refactor - no behaviour changes. (Unless I messed up.)
While working on some reorganisation of the
deploy
module, I noticed we had some instance methods that didn't useself
and in fact seemed more concerned with theCloudClient
than with theDeployCommand
. For me it felt more readable to pull them out as extension methods on theCloudClientInterface
. (My main interest was in moving code out ofDeployCommand
, which could be done without traitifying. But this felt nicer.)I also noticed that
commands::get_app_id_cloud
andDeployCommand::try_get_app_id_cloud
did the same thing (modulo oneanyhow::Context
), so unified them.I removed the
_cloud
suffixes which were inherited from earlier Spin code where they had to be distinguished from Platform (_hippo
) versions of the operations. The suffix is no longer needed in the cloud-specific plugin. I also took the opportunity to change the argument order and make some strings into&str
because reduced the need for repeated cloning.