Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kv): shorten KV link store identifier to just 'store' #175

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix(kv): shorten KV link store identifier to just 'store' #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/commands/link.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ pub struct KeyValueStoreLinkCommand {
/// The app that will be using the key value store
app: String,
/// The key value store that the app will refer to by the label
#[clap(short = 's', long = "key-value-store")]
key_value_store: String,
#[clap(short = 's', long = "store")]
kate-goldenring marked this conversation as resolved.
Show resolved Hide resolved
store: String,
}

impl LinkCommand {
Expand Down Expand Up @@ -95,7 +95,7 @@ impl KeyValueStoreLinkCommand {
.collect::<Vec<_>>();
link(
client,
&self.key_value_store,
&self.store,
&self.app,
&self.label,
app_id,
Expand Down Expand Up @@ -471,7 +471,7 @@ mod link_tests {
async fn test_key_value_store_link_error_store_does_not_exist() -> Result<()> {
let command = KeyValueStoreLinkCommand {
app: "app".to_string(),
key_value_store: "does-not-exist".to_string(),
store: "does-not-exist".to_string(),
label: "label".to_string(),
common: Default::default(),
};
Expand All @@ -497,7 +497,7 @@ mod link_tests {
async fn test_key_value_store_link_succeeds_when_store_exists() -> Result<()> {
let command = KeyValueStoreLinkCommand {
app: "app".to_string(),
key_value_store: "kv1".to_string(),
store: "kv1".to_string(),
label: "label".to_string(),
common: Default::default(),
};
Expand Down