Update deploy to use OCI as distribution mechanism #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radu Matei <radu.matei@fermyon.com>
Signed-off-by: Radu Matei <radu.matei@fermyon.com>
Signed-off-by: Radu Matei <radu.matei@fermyon.com>
Signed-off-by: Radu Matei <radu.matei@fermyon.com>
bacongobbler
requested changes
Jun 22, 2023
| let bindle_id = spin_bindle::prepare_bindle(&self.app()?, buildinfo, dest_dir) | ||
| .await | ||
| .map_err(crate::wrap_prepare_bindle_error)?; | ||
| println!("Uploading {} to Fermyon Cloud...", reference); |
There was a problem hiding this comment.
Would you mind removing the registry URL here? I don't think there's any action we want users to take with this URL. e.g. they can't use spin registry push or spin registry pull with this URL IIRC.
There was a problem hiding this comment.
That's a good point. I wasn't sure it should be there to begin with, so I'll remove it.
There was a problem hiding this comment.
This has been updated in 675e8f4
|
Closing in favor of #57, updated with the latest changes from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.