update user agent to include spin version #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
approved these changes
Aug 21, 2023
crates/cloud/src/client.rs
Outdated
| env!("CARGO_PKG_NAME"), | ||
| env!("CARGO_PKG_VERSION") | ||
| env!("CARGO_PKG_VERSION"), | ||
| std::env::var("SPIN_VERSION").unwrap_or_default() |
There was a problem hiding this comment.
I would maybe do this to help out UA parsers that expect something after the /:
Suggested change
| std::env::var("SPIN_VERSION").unwrap_or_default() | |
| std::env::var("SPIN_VERSION").unwrap_or_else(|| "0".to_string()) |
karthik2804
force-pushed
the
better_user_agent
branch
from
47779fa
to
043b369
Compare
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
better_user_agent
branch
from
043b369
to
bee0d23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14