fix listing apps conditional #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
reviewed
Aug 24, 2023
src/commands/apps.rs
Outdated
| @@ -45,7 +45,7 @@ impl AppsCommand { | |||
| AppsCommand::List(cmd) => { | |||
| let client = create_cloud_client(cmd.common.deployment_env_id.as_deref()).await?; | |||
| let mut app_list_page = client.list_apps(DEFAULT_APPLIST_PAGE_SIZE, None).await?; | |||
| if app_list_page.total_items > 0 { | |||
| if app_list_page.total_items < 0 { | |||
There was a problem hiding this comment.
Can be equal to zero as well
Suggested change
| if app_list_page.total_items < 0 { | |
| if app_list_page.total_items <= 0 { |
Signed-off-by: Adam Reese <adam@reese.io>
adamreese
force-pushed
the
fix/list-apps
branch
from
c8e5513
to
c77b710
Compare
itowlson
approved these changes
Aug 24, 2023
karthik2804
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.