Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify local dev loop #72

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Simplify local dev loop #72

merged 1 commit into from
Sep 1, 2023

Conversation

itowlson
Copy link
Contributor

Proposal for fixing #36.

Note this does not change CI, so I haven't worried about how to sync the version or maintain the compatibility declaration. Those would be good to think about as pluginify features if people find this useful.

Copy link
Collaborator

@karthik2804 karthik2804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one teeny suggestion

README.md Show resolved Hide resolved
Copy link
Collaborator

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@vdice vdice mentioned this pull request Aug 25, 2023
Copy link
Member

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice. thank you!

```sh
spin plugin install -f ./plugin/cloud.json
cargo build --release
spin pluginify --install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error when trying to run the command:

Error: Cannot read settings file spin-pluginify.toml: No such file or directory (os error 2)

I didn't get this the first time I ran these commands so I'm a little confused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelleN You've not by any chance switched back to the main branch or anything like that? Does the file exist when you ls it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelleN given other approvals I'm going to merge this - if you continue to hit the file not found error then please flag it up and I'll investigate further

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson merged commit a653430 into fermyon:main Sep 1, 2023
8 checks passed
@vdice vdice mentioned this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants