Update SQLite subcommand to use links #75
Conversation
| storage_id: &str, | ||
| create_default_database: bool, | ||
| ) -> Result<Uuid> { | ||
| pub async fn add_app(&self, name: &str, storage_id: &str) -> Result<Uuid> { |
There was a problem hiding this comment.
I know this was already called add_app before, but I do wonder why we didn't call it create_app? There are other places where we might want to add an app to something that this might become even more confusing.
|
I'm going to mark this as ready to review, because it works well already. |
Create links subcommand Use new upstream APIs for linking apps to databases Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com> Co-authored-by: Ryan Levick <ryan.levick@fermyon.com>
|
@rylev this is a lot of commits but rebasing was a headache. If you aren't opposed, i copied all changes to a different branch. I could push that branch into this one to get us down to one commit: https://github.com/fermyon/cloud-plugin/compare/main...kate-goldenring:sql-links-cli?expand=1 |
|
That might be easiest... I wouldn't be opposed. |
kate-goldenring
force-pushed
the
sqlite-v2-cli
branch
from
dc8a4b2
to
fc792f8
Compare
|
@rylev done 🎉 |
|
@rylev i think we should figure out the following before merging:
|
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
|
Talking it over with others, we've decided to go with random name generation for now. We can always revisit this in the future. |
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rylev
force-pushed
the
sqlite-v2-cli
branch
from
77ddf24
to
f151ca4
Compare
PR for managing databases and links.