Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not offer --version on subcommands #88

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

itowlson
Copy link
Contributor

Fixes #83.

As noted on that issue, before merging this we should understand the intent behind having the propagate_version flag there in the first place. @kate-goldenring git blame has your name on the commit, though I think several people contributed to that first cut - do you know why this was set?

Before:

$ spin cloud variables -V
spin-cloud-variables 0.2.0 (78c325a 2023-09-14)

After:

$ spin cloud variables -V
error: Found argument '-V' which wasn't expected, or isn't valid in this context

        If you tried to supply `-V` as a value rather than a flag, use `-- -V`

USAGE:
    spin cloud variables <SUBCOMMAND>

For more information try --help

# Still works on top-level command
$ spin cloud -V
spin-cloud 0.2.0 (78c325a 2023-09-14)

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Copy link
Collaborator

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itowlson I am not sure why i added it and this is surely needed removed. Thank you!

@itowlson itowlson merged commit 1724018 into fermyon:main Sep 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spin cloud apps list --help for --V, --version is confusing
2 participants