Add get app subcommand to get app details #94
Conversation
src/commands/apps.rs
Outdated
| @@ -11,6 +11,8 @@ pub enum AppsCommand { | |||
| List(ListCommand), | |||
| /// Delete an app deployed in Fermyon Cloud | |||
| Delete(DeleteCommand), | |||
| /// Get Details about a deployed app in Fermyon Cloud | |||
| Get(GetCommand), | |||
There was a problem hiding this comment.
Get seems not quite the right name to me. What about Describe or Info? Maybe Get is right here. Is there a CLI you've seen that you're modeling after?
There was a problem hiding this comment.
I was just using the HTTP method here and it looked like it was descriptive enough of "get" app info - I am open to suggestions here.
One possibility might be get-info?
There was a problem hiding this comment.
Why get-info over just info? Maybe we take a vote in chat? I feel like to me, the following is displaying info, and spin cloud apps info "lottery" feels clearer. "get" like you mention is informative to HTTP method types but IMO CLIs require another level of specificity.
$ spin cloud apps get "lottery"
Name: lottery
Description: Draw a Magic 8 Ball Winner
URL: https://workshoplottery.fermyon.app
karthik2804
force-pushed
the
apps/get_app
branch
from
4fb7f0e
to
e5119f9
Compare
|
@itowlson I have addressed the comments. |
karthik2804
force-pushed
the
apps/get_app
branch
from
e5119f9
to
ea5d3d4
Compare
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
apps/get_app
branch
from
ea5d3d4
to
423ae7f
Compare
| match val.validation_status { | ||
| DomainValidationStatus::InProgress => { | ||
| if let Some(url) = app.channels[0].domain.as_ref() { | ||
| println!("URL: https://{}", url); |
There was a problem hiding this comment.
wow, I let one of my error messages stray into column 81, and cargo fmt gets mediaeval on my code with a rusty fork, but you have 9 levels of indent and it's all "right this way Mister Karthik can I escort you to the VIP zone". THE INJUSTICE
More seriously... I am appreciating the additional refinement of the UI, but the downside is it has made this function very long and very deeply indented. I'd strongly encourage breaking it up - ideally into command handlers, but at least pulling out some of the analysis and print logic into helpers. It's not a blocker though.
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
|
@kate-goldenring I have renamed the command to |
This PR adds a get subcommand to apps to allow for getting details about an app. It helps with getting the Base URL of apps quickly without having to open up the cloud UI.