Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding http-auth-middleware to SUH #1033

Merged
merged 9 commits into from
Nov 9, 2023
Merged

Conversation

macolso
Copy link
Contributor

@macolso macolso commented Nov 7, 2023

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date` are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep '^M' | wc -l and expect 0 as a result)
  • Has passed bart check
  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

Signed-off-by: macolso <mackenzie.olson@fermyon.com>
Signed-off-by: macolso <mackenzie.olson@fermyon.com>
@macolso macolso requested a review from tpmccallum November 7, 2023 20:36
Signed-off-by: macolso <mackenzie.olson@fermyon.com>
cargo install --git https://github.com/bytecodealliance/cargo-component cargo-component
```

* Install a fork of [wasm-tools]():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

content/api/hub/sample_http_auth_middleware.md Outdated Show resolved Hide resolved
cargo install --git https://github.com/dicej/wasm-tools --branch wasm-compose-resource-imports wasm-tools --locked
```

* Install latest [Spin](https://github.com/fermyon/spin)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not direct them to the Install page in the docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. I've modified the URL.

macolso and others added 3 commits November 8, 2023 09:33
Co-authored-by: itowlson <github@hestia.cc>
Signed-off-by: MacKenzie Olson <mackenzie.olson@fermyon.com>
Signed-off-by: MacKenzie Olson <mackenzie.olson@fermyon.com>
content/api/hub/sample_http_auth_middleware.md Outdated Show resolved Hide resolved
content/api/hub/sample_http_auth_middleware.md Outdated Show resolved Hide resolved
Timothy McCallum added 3 commits November 9, 2023 10:05
Signed-off-by: tpmccallum tim.mccallum@fermyon.com

Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum tim.mccallum@fermyon.com

Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum tim.mccallum@fermyon.com

Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
@tpmccallum tpmccallum merged commit 0d4796c into fermyon:main Nov 9, 2023
@karthik2804 karthik2804 deleted the middleware-suh branch November 14, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants