Add links to JavaScript SDK reference #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
approved these changes
Nov 14, 2023
content/spin/v2/http-trigger.md
Outdated
| In JavaScript or TypeScript, the handler is identified by name. It must be called `handleRequest`. The way you declare it is slightly different between the two languages. | ||
|
|
||
| In **JavaScript**, `handleRequest` is declared as `export async function`. It takes a JsvaScript object representing the request, and returns a response object. The fields of these objects are exactly the same as in TypeScript: | ||
| In **JavaScript**, `handleRequest` is declared as `export async function`. It takes a JsvaScript [object representing the request](https://fermyon.github.io/spin-js-sdk/interfaces/HttpRequest.html), and returns a [response object](https://fermyon.github.io/spin-js-sdk/interfaces/HttpResponse.html). The fields of these objects are exactly the same as in TypeScript: |
There was a problem hiding this comment.
Suggested change
| In **JavaScript**, `handleRequest` is declared as `export async function`. It takes a JsvaScript [object representing the request](https://fermyon.github.io/spin-js-sdk/interfaces/HttpRequest.html), and returns a [response object](https://fermyon.github.io/spin-js-sdk/interfaces/HttpResponse.html). The fields of these objects are exactly the same as in TypeScript: | |
| In **JavaScript**, `handleRequest` is declared as `export async function`. It takes a JavaScript [object representing the request](https://fermyon.github.io/spin-js-sdk/interfaces/HttpRequest.html), and returns a [response object](https://fermyon.github.io/spin-js-sdk/interfaces/HttpResponse.html). The fields of these objects are exactly the same as in TypeScript: |
There was a problem hiding this comment.
Nice spot! Thanks!
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
js-reference-links
branch
from
3cd3418 to
c1a860c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(also contains a couple of unrelated typo fixes because the spell checker was yelling at me)
Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title,template, anddate` are all settemplates/*.hbsfiles) that points to a document.mdthat is set to publish in the future? If so please only publish the.mdand.hbschanges in real-time (otherwise there will be a menu item pointing to a.mdfile that does not exist)cat -ve <filename> | grep '^M' | wc -land expect 0 as a result)bart checkPREVIEW_MODE=1and runnpm run stylesto update styling)npm run testand resolved all errors