Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spin.toml): manifest to v2 syntax; redirect module to 0.1.0 #1071

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

vdice
Copy link
Member

@vdice vdice commented Dec 4, 2023

  • Update spin.toml to v2 syntax
  • Update the redirect module to 0.1.0 (now spin-based; no longer wagi-based)

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Copy link

github-actions bot commented Dec 4, 2023

🚀 preview deployed successfully to Fermyon Cloud and available at https://fermyon-developer-wkr4hndj.fermyon.app

@tpmccallum
Copy link
Contributor

This looks great @vdice
The preview works perfectly; is there anything you would recommend I go ahead and test on purpose?
Otherwise LGTM.

@vdice
Copy link
Member Author

vdice commented Dec 4, 2023

Thanks @tpmccallum! My only question mark is the spin-version-proxy component. Notice how it has changed from allowed_http_hosts = ["self"] to allowed_outbound_hosts = ["http://self"] which I understand and expect to be functionally equivalent -- but can we double-check that this component/logic is working as intended?

@tpmccallum
Copy link
Contributor

Thanks so much, @vdice - great info.
That spin version proxy appears to be working perfectly.
If I hit the /spin/ URL (without specifying a version):

Screenshot 2023-12-05 at 09 16 28

It correctly redirects to the v2 version:

Screenshot 2023-12-05 at 09 16 37

In addition, if I toggle between version 1 and 2 it works as intended.

LGTM and good to merge.

@vdice vdice merged commit 4e40cc9 into main Dec 4, 2023
3 checks passed
@vdice vdice deleted the chore/v2-manifest branch December 4, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants