Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating limitations of custom domains #1127

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

tpmccallum
Copy link
Contributor

@tpmccallum tpmccallum commented Jan 5, 2024

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date` are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep '^M' | wc -l and expect 0 as a result)
  • Has passed bart check

$ bart check content/cloud/faq.md
✅ content/cloud/faq.md
$ bart check content/cloud/custom-domain.md
✅ content/cloud/custom-domain.md
$ bart check content/cloud/custom-domains-tutorial.md
✅ content/cloud/custom-domains-tutorial.md

  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
@tpmccallum tpmccallum requested review from itowlson and macolso January 5, 2024 01:46
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
@tpmccallum tpmccallum merged commit 2dd480d into fermyon:main Jan 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants