0.7.0 Cloud Plugin update - ready for review #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
tpmccallum
changed the title
kate-goldenring
requested changes
Jan 29, 2024
There was a problem hiding this comment.
I suggested a paragraph for the change log and mentioned a couple updates to the CLI. Thanks @tpmccallum!
Signed-off-by: Taylor Olson <taylor.olson@fermyon.com>
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
9 tasks
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
macolso
reviewed
Jan 31, 2024
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Co-authored-by: MacKenzie Olson <mackenzie.olson@fermyon.com> Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title,template, anddateare all settemplates/*.hbsfiles) that points to a document.mdthat is set to publish in the future? If so please only publish the.mdand.hbschanges in real-time (otherwise there will be a menu item pointing to a.mdfile that does not exist)cat -ve <filename> | grep '^M' | wc -land expect 0 as a result)bart check$ bart check content/cloud/changelog/spin-cloud-v0-7-0.md
✅ content/cloud/changelog/spin-cloud-v0-7-0.md
$ bart check content/cloud/cloud-command-reference.md
Error rendering markdown: Error rendering "Unnamed template" line 44, col 1: Helper not defined: "tabs"
✅ content/cloud/cloud-command-reference.md
PREVIEW_MODE=1and runnpm run stylesto update styling)npm run testand resolved all errorstodoand replaced with correct information?