-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spin kinesis trigger plugin info #1390
Conversation
Signed-off-by: Darwin Boersma <darwin@sadlark.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a couple of suggestions.
You can install the plugin using the following command: | ||
|
||
```sh | ||
spin plugins install --url https://github.com/ogghead/spin-trigger-kinesis/releases/download/canary/trigger-kinesis.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this has now been added to the registry, we can install via
spin plugins install trigger-kinesis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I listed the canary because (currently) it includes features that aren't in a tagged version, and I saw a lot of trigger plugins on Spin hub doing the same (e.g. https://developer.fermyon.com/hub/preview/plugin_sqs_trigger). My hope is to swap this once the plugin is not under active feature development (planning 0.4 to be a longer term stable release), but happy to swap it now if that's preferred. Let me know your thoughts!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not really have a strong preference but I think the case with other plugins in the hub might be half of them are not published to the spin plugin registry.
Co-authored-by: Karthik Ganeshram <karthik.ganeshram@fermyon.com> Signed-off-by: Darwin Boersma <darwin.boersma@gmail.com>
I will merge this once CI passes. Thanks for this @ogghead |
Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title
,template
, anddate
are all settemplates/*.hbs
files) that points to a document.md
that is set to publish in the future? If so please only publish the.md
and.hbs
changes in real-time (otherwise there will be a menu item pointing to a.md
file that does not exist)cat -ve <filename> | grep $'\r' | wc -l
and expect 0 as a result)bart check
bart check content/api/hub/plugin_spin_kinesis_trigger.md
✅ content/api/hub/plugin_spin_kinesis_trigger.md
PREVIEW_MODE=1
and runnpm run styles
to update styling)npm run test
and resolved all errorsAll the errors were transient. The links are valid!