-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS key-value store configuration #1423
Conversation
462d607
to
e71c17f
Compare
e71c17f
to
3f34b24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny change for clarity, thank you for creating this!
3f34b24
to
4452c48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thank you for adding this!
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
4452c48
to
0eb25d3
Compare
Does this PR need any additional work @itowlson? Seems like it failed build due to unrelated changes |
@ogghead Yeah those links are fixed on main and I will force bypass them when the time comes. I don't believe any more work is needed; it remains open because we hold off merging feature content until the feature is in a release (because merging auto publishes), and I believe AWS KV didn't quite make it into 3.0. |
That makes sense, thank you for the context! |
Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title
,template
, anddate
are all settemplates/*.hbs
files) that points to a document.md
that is set to publish in the future? If so please only publish the.md
and.hbs
changes in real-time (otherwise there will be a menu item pointing to a.md
file that does not exist)cat -ve <filename> | grep $'\r' | wc -l
and expect 0 as a result)bart check
PREVIEW_MODE=1
and runnpm run styles
to update styling)npm run test
and resolved all errors