Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS key-value store configuration #1423

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

itowlson
Copy link
Contributor

  • @ogghead (can't add you as a reviewer but would appreciate any comments you have - thanks!)

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep $'\r' | wc -l and expect 0 as a result)
  • Has passed bart check
  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

@itowlson itowlson added the spin-3.1 Landing in Spin 3.1 label Nov 22, 2024
@itowlson itowlson force-pushed the aws-dynamo-kv-config branch from 462d607 to e71c17f Compare November 22, 2024 00:34
@itowlson itowlson linked an issue Nov 22, 2024 that may be closed by this pull request
content/spin/v3/dynamic-configuration.md Outdated Show resolved Hide resolved
content/spin/v3/dynamic-configuration.md Outdated Show resolved Hide resolved
@itowlson itowlson force-pushed the aws-dynamo-kv-config branch from e71c17f to 3f34b24 Compare November 22, 2024 00:57
@itowlson itowlson requested a review from ogghead November 22, 2024 00:57
Copy link
Contributor

@ogghead ogghead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny change for clarity, thank you for creating this!

content/spin/v3/dynamic-configuration.md Outdated Show resolved Hide resolved
@itowlson itowlson force-pushed the aws-dynamo-kv-config branch from 3f34b24 to 4452c48 Compare November 22, 2024 01:12
@itowlson itowlson requested a review from ogghead November 22, 2024 01:13
Copy link
Contributor

@ogghead ogghead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you for adding this!

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson force-pushed the aws-dynamo-kv-config branch from 4452c48 to 0eb25d3 Compare November 24, 2024 19:57
@ogghead
Copy link
Contributor

ogghead commented Dec 17, 2024

Does this PR need any additional work @itowlson? Seems like it failed build due to unrelated changes

@itowlson
Copy link
Contributor Author

@ogghead Yeah those links are fixed on main and I will force bypass them when the time comes. I don't believe any more work is needed; it remains open because we hold off merging feature content until the feature is in a release (because merging auto publishes), and I believe AWS KV didn't quite make it into 3.0.

@ogghead
Copy link
Contributor

ogghead commented Dec 18, 2024

it remains open because we hold off merging feature content until the feature is in a release (because merging auto publishes), and I believe AWS KV didn't quite make it into 3.0.

That makes sense, thank you for the context!

@itowlson itowlson merged commit f004dd2 into fermyon:main Dec 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spin-3.1 Landing in Spin 3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS key-value backend
4 participants