Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around Cloud plugin install woe #1438

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

itowlson
Copy link
Contributor

@itowlson itowlson commented Dec 4, 2024

Addresses fermyon/spin#2946.

Until fermyon/spin#2947 is part of the release, the install script will fail if a pre-0.10 Cloud plugin is already installed. This inserts a workaround so that the install can completely successfully even before that fix lands.

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep $'\r' | wc -l and expect 0 as a result)
  • Has passed bart check
  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson merged commit 5211df8 into fermyon:main Dec 4, 2024
3 checks passed
@mikkelhegn
Copy link
Member

Do we need to do similar for Homebrew?

@kate-goldenring
Copy link
Contributor

@mikkelhegn good point. Yes, for upgrades, this is also needed in the homebrew formula. Created a PR for that here: fermyon/homebrew-tap#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants