Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest of Applications section to v2 #976

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

itowlson
Copy link
Contributor

@itowlson itowlson commented Oct 30, 2023

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date` are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep '^M' | wc -l and expect 0 as a result)
  • Has passed bart check

✅ content/spin/v2/build.md
✅ content/spin/v2/running-apps.md
✅ content/spin/v2/spin-application-structure.md

  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
Screenshot 2023-10-31 at 09 24 42
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

@itowlson itowlson requested a review from tpmccallum October 30, 2023 01:36
Copy link
Contributor

@tpmccallum tpmccallum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpmccallum
Copy link
Contributor

Just added a : to the end of a paragraph (that was written by someone else, at another time). Great PR @itowlson thanks!!!

@itowlson
Copy link
Contributor Author

Colons are my arch-nemesis, or at least an assistant junior nemesis. I will pull and squash - thanks!

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson force-pushed the get-industrial-revolution branch from 3417c20 to 6bec741 Compare October 30, 2023 23:38
@itowlson itowlson merged commit 9edb521 into fermyon:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants