Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced section to v2 #987

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Advanced section to v2 #987

merged 1 commit into from
Oct 31, 2023

Conversation

itowlson
Copy link
Contributor

@itowlson itowlson commented Oct 31, 2023

There didn't seem to be too many changes here but my brain has turned to mush so 🤷

This should be it apart from the tutorials and going back over the triggers and API sections for snazzy new features since the original update.

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date` are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep '^M' | wc -l and expect 0 as a result)
  • Has passed bart check

✅ content/spin/v2/deploying-to-fermyon.md
✅ content/spin/v2/extending-and-embedding.md
✅ content/spin/v2/template-authoring.md

  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive

Screenshot 2023-10-31 at 14 10 37

  • Have tested with npm run test and resolved all errors
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson requested a review from tpmccallum October 31, 2023 02:11
@itowlson
Copy link
Contributor Author

Forgot to say - I did not update the v2 dynamic config page because #985 is in progress - when that lands we can mirror the changes to v2 with tweaks to the names.

Copy link
Contributor

@tpmccallum tpmccallum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itowlson itowlson merged commit 8a5f30e into fermyon:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants