-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New readme #1333
Merged
Merged
New readme #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-matei
reviewed
Mar 29, 2023
radu-matei
reviewed
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme looks great, I have one non-blocking question about it.
You need to rebase the PR against the newest main to avoid the conflicts and old commits.
itowlson
requested changes
Mar 29, 2023
melissaklein24
force-pushed
the
new_readme
branch
from
March 29, 2023 21:13
c5738c0
to
46c1a07
Compare
Signed-off-by: Melissa Klein <melissa.klein@fermyon.com>
Signed-off-by: Melissa Klein <melissa.klein@fermyon.com>
Signed-off-by: Melissa Klein <melissa.klein@fermyon.com>
Signed-off-by: Melissa Klein <melissa.klein@fermyon.com>
melissaklein24
force-pushed
the
new_readme
branch
from
March 29, 2023 21:21
46c1a07
to
e63a380
Compare
…links to the documentation Signed-off-by: Melissa Klein <melissa.klein@fermyon.com>
itowlson
approved these changes
Apr 13, 2023
Co-authored-by: itowlson <github@hestia.cc> Signed-off-by: Melissa Klein <43244625+melissaklein24@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README with additional example, language support table, and other updates.