-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bootstrapping script for dev container to update Rust and Wasm3… #1382
Conversation
331dde7
to
0f08994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thanks!
Hi @itowlson do I need to do something more (happy to) to merge this? Commit is signed-off by me already. |
@suneetnangia it looks like you need to GPG-sign the commit - the link in the "merging is blocked" message has the info. Apologies for not spotting this earlier! |
Signed-off-by: Suneet Nangia <suneetnangia@gmail.com>
cb4cd63
to
88353ba
Compare
Thanks, done now, see if that's ok. |
examples/spin-timer/Cargo.lock
Outdated
@@ -3481,6 +3481,18 @@ dependencies = [ | |||
"wit-bindgen-wasmtime", | |||
] | |||
|
|||
[[package]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused. Why are these changes part of this PR? Perhaps these are unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's by error, let me remove. Thanks for spotting it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: Suneet Nangia <suneetnangia@gmail.com>
Cargo.lock
Outdated
@@ -2129,9 +2129,9 @@ dependencies = [ | |||
|
|||
[[package]] | |||
name = "h2" | |||
version = "0.3.16" | |||
version = "0.3.17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the same issue as the other file. This lock file should not need to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done...
Signed-off-by: Suneet Nangia <suneetnangia@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you!
This allows dev container to install a latest stable version of Rust toolchain and the required wasm32 targets i.e. wasm32-wasi wasm32-unknown-unknown