Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bootstrapping script for dev container to update Rust and Wasm3… #1382

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

suneetnangia
Copy link
Contributor

This allows dev container to install a latest stable version of Rust toolchain and the required wasm32 targets i.e. wasm32-wasi wasm32-unknown-unknown

@suneetnangia suneetnangia marked this pull request as ready for review April 14, 2023 16:10
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@suneetnangia
Copy link
Contributor Author

Hi @itowlson do I need to do something more (happy to) to merge this? Commit is signed-off by me already.

@itowlson
Copy link
Contributor

@suneetnangia it looks like you need to GPG-sign the commit - the link in the "merging is blocked" message has the info. Apologies for not spotting this earlier!

Signed-off-by: Suneet Nangia <suneetnangia@gmail.com>
@suneetnangia
Copy link
Contributor Author

@suneetnangia it looks like you need to GPG-sign the commit - the link in the "merging is blocked" message has the info. Apologies for not spotting this earlier!

Thanks, done now, see if that's ok.

@@ -3481,6 +3481,18 @@ dependencies = [
"wit-bindgen-wasmtime",
]

[[package]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. Why are these changes part of this PR? Perhaps these are unrelated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's by error, let me remove. Thanks for spotting it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Signed-off-by: Suneet Nangia <suneetnangia@gmail.com>
Cargo.lock Outdated
@@ -2129,9 +2129,9 @@ dependencies = [

[[package]]
name = "h2"
version = "0.3.16"
version = "0.3.17"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the same issue as the other file. This lock file should not need to be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done...

Signed-off-by: Suneet Nangia <suneetnangia@gmail.com>
Copy link
Collaborator

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you!

@itowlson itowlson merged commit 7b42d08 into fermyon:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants