Add Azure CosmosDB implementation for KV #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-matei
commented
May 8, 2023
radu-matei
commented
May 8, 2023
| async fn get_keys(&self) -> Result<Vec<String>, Error> { | ||
| let client = self.client.lock().await; | ||
| let query = client | ||
| .query_documents(Query::new("SELECT * FROM c".to_string())) |
There was a problem hiding this comment.
I think we can tweak the query to only return c.id instead of the entire document?
radu-matei
force-pushed
the
feat/kv-azure-cosmos
branch
from
06587d7
to
ae62288
Compare
This commit adds an implementation of Azure CosmosDB as a backend for Spin's key/value store. Specifically, this uses a CosmosDB account created with the NoSQL API, and requires the following contents for the runtime configuration file: ```toml [key_value_store.default] type = "azure_cosmos" key = "<key>" account = "<cosmos-account>" database = "<cosmos-database>" container = "<cosmos-container>" The CosmosDB container *must* be created with the default partition key, `/id`. To test the changes in this commit, the runtime configuration file above can be passed (and can be further tested with the KV explorer template): ```bash $ spin up --runtime-config-file runtime-config.toml --key-value keyfromcli=valuefromcli Storing default key-value data to Azure CosmosDB ``` Signed-off-by: Radu Matei <radu.matei@fermyon.com> Update CosmosDB backend for KV Signed-off-by: Radu Matei <radu.matei@fermyon.com> Update CosmosDB backend for KV Signed-off-by: Radu Matei <radu.matei@fermyon.com> Update CosmosDB backend for KV Signed-off-by: Radu Matei <radu.matei@fermyon.com>
radu-matei
force-pushed
the
feat/kv-azure-cosmos
branch
from
ae62288
to
4a93396
Compare
rylev
reviewed
May 9, 2023
This commit removes the `OnceCell` dependency from the Azure CosmosDB backend for KV and simplifies the client setup and creation. Co-authored-by: Ryan Levick <ryan.levick@fermyon.com> Signed-off-by: Radu Matei <radu.matei@fermyon.com>
Signed-off-by: Radu Matei <radu.matei@fermyon.com>
|
@rylev and I paired on this earlier today and addressed most of the feedback. This should be ready for a re-review. Thanks! |
Mossaka
approved these changes
May 10, 2023
The Spin key-value API for `delete` states that "no error is raised if a tuple did not previously exist for key". This commit updates the Azure CosmosDB implementation to follow that. Signed-off-by: Radu Matei <radu.matei@fermyon.com>
rylev
reviewed
May 11, 2023
Signed-off-by: Radu Matei <radu.matei@fermyon.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
fibonacci1729
approved these changes
May 15, 2023
|
Documentation for this is being worked on at fermyon/developer#611 and fermyon/developer#648 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an implementation of Azure CosmosDB as a backend for Spin's key/value store.
Specifically, this uses a CosmosDB account created with the NoSQL API, and requires the following contents for the runtime configuration file:
The CosmosDB container must be created with the default partition key,
/id:To test the changes in this commit, the runtime configuration file above
can be passed (and can be further tested with the KV explorer template):
Thanks to @fibonacci1729 for pairing on this one!
cc @Mossaka @devigned