feat(plugins): show description and homepage of installed plugin #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matheus Cardoso <matheus@cardo.so>
rylev
reviewed
May 15, 2023
Co-authored-by: Ryan Levick <me@ryanlevick.com> Signed-off-by: Matheus Cardoso <matheus@cardo.so>
cardoso
commented
May 15, 2023
Signed-off-by: Matheus Cardoso <matheus@cardo.so>
rylev
reviewed
May 15, 2023
Signed-off-by: Matheus Cardoso <matheus@cardo.so>
cardoso
force-pushed
the
feat/plugin_description
branch
from
804d39e
to
9244b78
Compare
| @@ -467,6 +467,17 @@ async fn try_install( | |||
| if continue_to_install(manifest, package, yes_to_all)? { | |||
| let installed = manager.install(manifest, package).await?; | |||
| println!("Plugin '{installed}' was installed successfully!"); | |||
|
|
|||
| if let Some(description) = manifest.description() { | |||
| println!("\nDescription:"); | |||
There was a problem hiding this comment.
Is there a reason we want this additional newline added to a println statement? I'm assuming it is a stylistic choice
There was a problem hiding this comment.
Without some additional line breaks it disappears with the rest of the output. A mild improvement though. I believe #1481 will address this without needing the line breaks.
kate-goldenring
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to give plugins a chance to display something once they're installed such as instructions or notices.
Showing the description would be a good start.
I also included the homepage (if it's HTTPS) as a good place to link to some documentation.