Add color to each step of spin build and spin up #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
approved these changes
May 22, 2023
There was a problem hiding this comment.
This looks fine - I have to admit I am a bit unsure about the "first word highlighted" look, but I expect that is unfamiliarity more than anything else. The best thing is to try it and see how people feel.
There are a couple of things that got deleted that need to be restored - the "no build command" output and the blank line before "Serving" - so technically this is "request changes," but they're trivial fixes and I wanted to save you waiting through another 24-hour review cycle. So please don't merge without them, but once done please don't feel the need to wait for another go-around.
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds green to the first word of each logical step in
spin buildandspin up.Current
New