Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go/sdk): Populate full url in request object #1528

Merged
merged 1 commit into from
May 30, 2023

Conversation

adamreese
Copy link
Member

This changes the request object to parse the full url rather than the uri. This correctly populates the Scheme, Host, and Query fields.

url.URL{
        Scheme:      "http",
        Opaque:      "",
        User:        (*url.Userinfo)(nil),
        Host:        "localhost:3000",
        Path:        "/hello/world",
        RawPath:     "",
        OmitHost:    false,
        ForceQuery:  false,
        RawQuery:    "foo=bar",
        Fragment:    "",
        RawFragment: "",
    },

This changes the request object to parse the full url rather than the
uri.  This correctly populates the Scheme, Host, and Query fields.

Signed-off-by: Adam Reese <adam@reese.io>
@adamreese adamreese merged commit 2deb753 into fermyon:main May 30, 2023
@adamreese adamreese deleted the fix/request-url branch May 30, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants