Use a vergen that handles spew in timestamp output #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
lann
reviewed
May 25, 2023
| @@ -87,7 +87,7 @@ e2e-testing = { path = "crates/e2e-testing" } | |||
|
|
|||
| [build-dependencies] | |||
| cargo-target-dep = { git = "https://github.com/fermyon/cargo-target-dep", rev = "b7b1989fe0984c0f7c4966398304c6538e52fe49" } | |||
| vergen = { version = "8", default-features = false, features = [ | |||
| vergen = { version = "^8.2.1", default-features = false, features = [ | |||
There was a problem hiding this comment.
FYI
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#caret-requirements
Caret requirements are an alternative syntax for the default strategy, ^1.2.3 is exactly equivalent to 1.2.3.
lann
approved these changes
May 25, 2023
fibonacci1729
approved these changes
May 25, 2023
|
@lann Thank you - TIL! I'm going to leave this as is if it works for @tpmccallum, but useful to know for the future! |
|
Voila - works great; thanks @itowlson Just to be sure I began from scratch and tried the normal installation - which failed again expectedly. I then tried your new command, and it installed Spin without any issues.
|
|
Thanks @tpmccallum! (And thanks Vergen folks for such a quick fix!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1531.
cc @tpmccallum - I think you are the only person who was able to repro this - if you have a moment to check the fix, please try:
Thanks!