SQLite manifest validation and tests #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like #1550 is going to land first so I have made this dependent on that (which means that it temporarily includes a couple of extra commits from over there). |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
|
Rebased and ready for review. |
rajatjindal
reviewed
Jun 3, 2023
| _: Option<Pin<Box<dyn AsyncBufRead>>>, | ||
| _: Option<Pin<Box<dyn AsyncBufRead>>>, | ||
| ) -> Result<()> { | ||
| assert_http_response( |
There was a problem hiding this comment.
may be use assert_status?
There was a problem hiding this comment.
This was copied from key_value_works... I will merge as stands (since you have approved and the phrasing on the comment sounds non-blocking), but am happy to update both places in a follow-up PR if you feel it's worth it. (assert_status does seem terser I agree.)
rajatjindal
approved these changes
Jun 3, 2023
fibonacci1729
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs page doesn't exist yet so I could take that line out and put it back in when we do the formal release of SQLite, but I'm not immensely motivated!