Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): Display required Spin version of incompatible plugins #1563

Merged

Conversation

kate-goldenring
Copy link
Contributor

fixes #1562

Currently listing plugins doesn't say what version of spin is requred:

$ spin plugins list
cloud 0.1.0 [requires other Spin version]
js2wasm 0.1.0
js2wasm 0.2.0
js2wasm 0.3.0 [requires other Spin version]
js2wasm 0.4.0
py2wasm 0.1.0
py2wasm 0.1.1
py2wasm 0.2.0 [installed]

This makes the list more informative:

$ spin plugins list
cloud 0.1.0 [requires Spin >=1.3]
js2wasm 0.1.0
js2wasm 0.2.0
js2wasm 0.3.0 [requires Spin <=0.7]
js2wasm 0.4.0
py2wasm 0.1.0
py2wasm 0.1.1
py2wasm 0.2.0 [installed]

Note: i messed with js2wasm manifest to make it incompat for demo purposes

Considerations

  • the plugin manifests allow for fairly complicated semver. We could run into this getting messy but it is unlikely

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and output looks great - thanks!

@@ -39,6 +39,9 @@ impl PluginManifest {
pub fn license(&self) -> &str {
self.license.as_ref()
}
pub fn spin_compatibility(&self) -> String {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super duper nit: line break before

@kate-goldenring kate-goldenring added this to the 1.3.0 milestone Jun 8, 2023
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@kate-goldenring kate-goldenring merged commit 414a285 into fermyon:main Jun 8, 2023
@kate-goldenring kate-goldenring deleted the plugin-list-desired-spin branch June 8, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List compatible spin version for plugins that are incompatible
2 participants