makefile and CI tweaks #1846
Merged
makefile and CI tweaks #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are some changes I made as part of fermyon#1553 despite not being specifically related to the goal of that PR. Now I'm splitting them out into their own PR. - Set `PATH` where appropriate to ensure the expected version of Spin is used to test (i.e. the one built from the current clone of the repository) rather than whatever happens to be installed on the user's machine. - Lint all examples as part of CI - and fix the lint warnings so we have a clean baseline Signed-off-by: Joel Dice <joel.dice@fermyon.com>
itowlson
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some changes I made as part of
#1553 despite not being specifically related to the goal of that PR. Now I'm splitting them out into their own PR.
Set
PATHwhere appropriate to ensure the expected version of Spin is used to test (i.e. the one built from the current clone of the repository) rather than whatever happens to be installed on the user's machine.Lint all examples as part of CI