Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run lints on Rust test cases #1884

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Run lints on Rust test cases #1884

merged 4 commits into from
Oct 13, 2023

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Oct 12, 2023

Runs linting over "tests/testcases/*/Cargo.toml" and changes Rust linting in CI to happen all together.

Unfortunately the linting job takes much longer now which would delay the other jobs from getting started. Instead of gating on linting passing, we now let everything run and cancel if linting fails.

.github/workflows/build.yml Outdated Show resolved Hide resolved
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
@rylev rylev enabled auto-merge October 13, 2023 07:26
@rylev rylev merged commit 666f1c3 into main Oct 13, 2023
9 checks passed
@rylev rylev deleted the more-linting branch April 24, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants