Templates for Manifest v2 and SDK v2 #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
templates-manifest-v2
branch
from
87b3cad
to
b24b8c3
Compare
|
I would like to merge this if the unit tests pass, despite it being only partial (and despite the e2e failure), to see if it unblocks e2e. The trouble we have is that e2e is using the templates from main not from the PR being tested, so I can't confirm that the changes here fully fix e2e without merging them. |
|
Although I am concerned that e2e is reporting Go and "registry" errors too. |
|
Ah... those need to run |
|
I have naughtily rolled a candidate fix for the other e2e tests into this PR. Your forgiveness is requested. |
lann
approved these changes
Oct 19, 2023
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
templates-manifest-v2
branch
from
6fbe2f1
to
ccdd7f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress! I'm putting it up so people can advise on the best way to show HTTP responses, bikeshed the template TOML, kick the tyres, etc.