doctor: Unbreak spin doctor for Manifest V2
#1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
commented
Oct 23, 2023
crates/doctor/tests/ui.rs
Outdated
There was a problem hiding this comment.
For now this just captures one change to the version diagnosis plus some smoke tests, but I think I'd like to migrate all the tests in this crate to this style.
lann
commented
Oct 23, 2023
| @@ -1,4 +1,4 @@ | |||
| spin_manifest_version = 2 | |||
| spin_manifest_version = 1 | |||
There was a problem hiding this comment.
Just the wrong type now.
lann
commented
Oct 23, 2023
| show_diagnosis(&*diagnosis); | ||
| let mut checkup = spin_doctor::Checkup::new(manifest_file)?; | ||
| let mut has_problems = false; | ||
| while let Some(PatientDiagnosis { diagnosis, patient }) = checkup.next_diagnosis().await? { |
There was a problem hiding this comment.
Most of the changes below are just reformatting due to un-nesting here.
itowlson
approved these changes
Oct 23, 2023
This doesn't add any V2 functionality, but prevents spurious errors on valid V2 manifests. Signed-off-by: Lann Martin <lann.martin@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't add any V2 functionality, but prevents spurious errors on valid V2 manifests.
Also simplifies
Checkup::for_each_diagnosisintoCheckup::next_diagnosis, which is much less finicky and not really any harder to use.