Fix watchexec missing files in subdirectories #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
radu-matei
approved these changes
Oct 30, 2023
lann
reviewed
Oct 30, 2023
| @@ -93,6 +94,7 @@ impl WatchCommand { | |||
|
|
|||
| let spin_bin = std::env::current_exe()?; | |||
| let manifest_file = spin_common::paths::resolve_manifest_file_path(&self.app_source)?; | |||
| let manifest_file = manifest_file.absolutize()?.to_path_buf(); // or watchexec misses files in subdirectories | |||
There was a problem hiding this comment.
BECAUSE REASONS LANN REASONS
We could probably absolutise at the last moment before we pass the directory to watchexec - I just get paranoid about capturing the true location as early as possible (a) so I don't need to remember to do it at all the last moments and (b) in case some other piece of code sneakily switches out the current directory from underneath me. thousand yard stare
We can iterate on this for sure though.
lann
approved these changes
Oct 30, 2023
vdice
approved these changes
Oct 30, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1981.