[Backport v2.0] Don't allow v2 components to be added to v1 manifest #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com> (cherry picked from commit 62d86b1)
|
@vdice I've put this in because it's something Mikkel raised and does not affect user or developer experience. But feel free to decline it if you want to keep 2.0 as frozen as possible - I'm completely sympathetic to that! |
|
@itowlson I'm fine with backporting if you'd like to see it in. I didn't get a chance to test this logic -- is the error obvious to the user when they add a componnent with a mismatched manifest version? |
|
@vdice I hope so. It prints |
vdice
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #2025 to v2.0