Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(telemetry): Provide the abililty to turn off the tracing-log compat layer in tracing-subscriber dep of telemetry #2501

Merged
merged 1 commit into from
May 13, 2024
Merged

ref(telemetry): Provide the abililty to turn off the tracing-log compat layer in tracing-subscriber dep of telemetry #2501

merged 1 commit into from
May 13, 2024

Conversation

calebschoepp
Copy link
Collaborator

No description provided.

@calebschoepp calebschoepp requested review from lann and radu-matei May 9, 2024 15:52
@calebschoepp calebschoepp force-pushed the tracing-log-compat branch 2 times, most recently from 7c06819 to c065d04 Compare May 9, 2024 22:30
@calebschoepp
Copy link
Collaborator Author

I tested to make sure that tracing::log::* is still being picked up in the main Spin binary. This is ready for review.

@calebschoepp
ref(telemetry): Provide the abililty to turn off the tracing-log comp…
735d0a4 
…at layer in tracing-subscriber dep of telemetry

Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
@calebschoepp calebschoepp force-pushed the tracing-log-compat branch from c065d04 to 735d0a4 Compare May 9, 2024 22:30
@lann
Copy link
Collaborator

lann commented May 10, 2024

What is the goal with this compat layer?

@radu-matei
Copy link
Member

ref spinkube/containerd-shim-spin#112

@calebschoepp
Copy link
Collaborator Author

What is the goal with this compat layer?

@lann the goal of the compat layer is to keep the tracing-log feature turned on when Spin is compiled as a standalone binary. This is so that we can still pick up any log::* emitted by upstream libraries. For example wasmparser uses log::* and not tracing::*.

@calebschoepp calebschoepp merged commit 424bff5 into fermyon:main May 13, 2024
17 checks passed
@calebschoepp calebschoepp deleted the tracing-log-compat branch May 13, 2024 17:40
@calebschoepp calebschoepp mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lann lann lann approved these changes

@radu-matei radu-matei Awaiting requested review from radu-matei

@kate-goldenring kate-goldenring Awaiting requested review from kate-goldenring

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calebschoepp @lann @radu-matei