Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subtle runtime config issues #2773

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix subtle runtime config issues #2773

merged 1 commit into from
Aug 27, 2024

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Aug 27, 2024

Two bugs:

  • Variables runtime config key is either variables_provider or config_provider
  • Change log_dir and state_dir logic to prefer explicitly provided options with a fallback to the runtime config toml if none was provided.

@rylev
Fix subtle runtime config issues.
fe17796 
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
@rylev rylev requested a review from lann August 27, 2024 13:56
@rylev rylev merged commit 84c87d2 into factors Aug 27, 2024
1 check passed
@rylev rylev deleted the more-path-fixes branch August 27, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lann lann lann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rylev @lann