Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templates for mandatory componentization #2789

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

lann
Copy link
Collaborator

@lann lann commented Aug 29, 2024

The Swift template is no longer usable due to the deprecation of running uncomponentized modules and issues with componentizing: #2774

The Grain template has been updated based on upstream advice: grain-lang/grain#2153

Closes #2774

@itowlson
Copy link
Contributor

itowlson commented Aug 29, 2024

There are some tests in the templates crate that use the templates from the Spin repo and make assertions by counting. The const for the expected total count is called TPLS_IN_THIS and will (I expect) need to be updated for 'unit' tests to pass.

const TPLS_IN_THIS: usize = 12;

Signed-off-by: Lann Martin <lann.martin@fermyon.com>
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann changed the title Remove grain and swift templates Update templates for mandatory componentization Aug 30, 2024
@lann lann enabled auto-merge August 30, 2024 18:33
@lann lann merged commit 7583fc5 into fermyon:main Aug 30, 2024
16 of 17 checks passed
@lann lann deleted the remove-grain-swift branch August 30, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift and Grain Templates Tests Not Working
2 participants